set log filename extension and avoid deleting incorrect files #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fxliang
commented
Mar 6, 2024
- close temp夾紀錄檔副檔名理應統一（如log）而非一堆每次不同的數 home#1484
- avoid deleting incorrect files, some cases like rime.lua with rime_api_console
lotem
requested changes
Mar 6, 2024
lotem
approved these changes
Mar 6, 2024
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
* set log filename extension ".log" * avoid deleting non-log file or not log files of current app --------- Co-authored-by: 居戎氏 <[email protected]>
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
* set log filename extension ".log" * avoid deleting non-log file or not log files of current app --------- Co-authored-by: 居戎氏 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.