This repository was archived by the owner on Feb 24, 2020. It is now read-only.
Godeps: bump appc to v0.7.0, etc #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9762c4 to
0fba091
Compare
Unfortunately we have a slight tangling between some dependencies like appc/spec + appc/docker2aci, appc/docker2aci + coreos/ioprogress, etc. As such, for this change we need to bump them in lockstep or individual commits along the way will be broken. Hence this commit includes the following: - bump appc to v0.7.0 - switch from GoogleCloudPlatform to k8s.io - bump appc/docker2aci and coreos/ioprogress - add golang.org/x/crypto/ssh/terminal for coreos/ioprogress - change cgroup package to reference k8s.io
0fba091 to
87dbef0
Compare
|
The new ioprogress library means that there's a one line change that should be made in |
|
@dgonyeo #1423 (comment) . this PR is just the bare minimum changes to have the codebase still compile/pass tests after the deps are bumped |
3 tasks
|
LGTM |
|
Will we have time to take further changes in appc/spec before the next rkt release? I am thinking of #1453 and appc/spec#498 (not implemented yet). |
alban
added a commit
that referenced
this pull request
Sep 23, 2015
Godeps: bump appc to v0.7.0, etc
|
@alban just to recap OOB discussion, I am happy to do a minor spec release and bump rkt - now that 0.7.0 has landed it should be much easier. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at this tangled web. Let's see what Semaphore says.