This repository was archived by the owner on Feb 24, 2020. It is now read-only.
rkt: removePod: fix switch order #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p.isExitedGarbage and p.isExited can both be true at the same time. Fix the tests order in the switch, so we don't move a pod to garbage if it is already in garbage. Fixes rkt#1620
43fbb56 to
a8a2372
Compare
|
lgtm I hate all those pod state bools, but people get mad at me when I do bitfields in go. |
|
y'all can click that merge button too |
jonboulle
added a commit
that referenced
this pull request
Oct 16, 2015
rkt: removePod: fix switch order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p.isExitedGarbage and p.isExited can both be true at the same time. Fix
the tests order in the switch, so we don't move a pod to garbage if it
is already in garbage.
Fixes #1620
/cc @vcaputo