This repository was archived by the owner on Feb 24, 2020. It is now read-only.
build: Some cleanups for verbosity control #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That will allow us to modify the stamp generation in just one place. Also, MAKE variables were escaped, so GNU Make can deduce that it is calling make recursively, so it can pass some important informations to them (mostly about jobserver, so -j4 works for child make processes too). https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html
This will allow us to modify directory removing stamps in one place.
It was required when depsgen glob had an "args" mode (taking files from command line, usually passed as a glob). But we replaced that with filelist, so call to shopt is not needed anymore.
There was a problem hiding this comment.
Naah, $$$$$$$$ would be a jackpot. I haven't got that yet, though.
|
LGTM |
iaguis
added a commit
that referenced
this pull request
Oct 27, 2015
build: Some cleanups for verbosity control
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to minimize the number of places to be modified when adding verbosity levels.
And some other small fixes.