Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Conversation

@krnowak
Copy link
Collaborator

@krnowak krnowak commented Oct 26, 2015

This updates the configure script and a documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/one//

@iaguis
Copy link
Member

iaguis commented Oct 26, 2015

LGTM. Merge on green after fixing the typos.

This commit cleans the configure.ac script and introduces following
changes:

- Rename --with-stage1-image flag to -with-stage1-default-location, no
  changes in meaning.

- Add --with-stage1-flavors option which take a comma-separated list
  of flavor names as a value. The specified flavors will be built. The
  default value depends on setup described below.

- Remove the --with-stage1 option in favor of different setup. When
  configuring a project, developer can use either a flavor setup or a
  detailed setup.

  The detailed setup has two flags - --with-stage1-default-name and
  --with-stage1-default-version. These can be used to specify some 3rd
  party stage1 image as a default. By default no stage1 flavors are
  built in this setup.

  The flavor setup has only one flag - --with-stage1-default-flavor.
  It takes a flavor name, which will become a default. The flavor must
  be a part of --with-stage1-flavors. Based on flavor name, stage1
  name and version are deduced (version is the same as rkt
  version). By default both coreos and kvm flavors are built in this
  setup and the first flavor in the list is the default.

- Require gpg only when either building coreos flavor or running
  functional tests.
`./configure` flags for building and selecting default stage1 image
have changed, so mention that in docs.

Also, do some cleanups, like quote some invocations properly and
remove trailing whitespace.
krnowak added a commit that referenced this pull request Oct 26, 2015
build: Allow building multiple stage1 images in one go
@krnowak krnowak merged commit d44b97d into rkt:master Oct 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants