This repository was archived by the owner on Feb 24, 2020. It is now read-only.
[RFC][WIP] rkt fly #1825
Closed
[RFC][WIP] rkt fly #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first version of "rkt fly" command which executes a single application image with no constraints or pod. It will be improved later to support uid shifts, improve the chroot logic, clean code. Patch based on the work of Jonathan Boulle <[email protected]> Signed-off-by: Djalal Harouni <[email protected]>
stat should be run after chroot(), so that it can work also when the rootfs is a symlink to another directory.
Signed-off-by: Djalal Harouni <[email protected]>
There was a problem hiding this comment.
@steveej Unshare works on the thread level here, so the following mount can still happen in host mount namespace.
But here we can use LockOSThread to make the mounting happen in the unshared thread. However since we don't have controls over the creation of goroutines, it can cause new threads to be cloned from this unshared threads. though it doesn't seem to cause a problem here.
But anyway it is unrecommended to use unshare in go :( golang/go#1954
/cc @vcaputo @jonboulle We hit such problems for a million times
There was a problem hiding this comment.
Thanks, I fixed that!
This is necessary when using the unshare syscall as it operates on a os-thread level.
4 tasks
|
Closing in favour of #1833 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
/var/lib/rkt/flights)