This repository was archived by the owner on Feb 24, 2020. It is now read-only.
build: Allow packagers to override stage1 version #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure.ac
Outdated
There was a problem hiding this comment.
Bah, thanks for spotting.
|
@krnowak Thanks! Can you explain in |
|
I suppose I will have to simply write a separate document about configure flags and their uses and link to it from the other places that mention configure script or its parameters. |
|
@alban: ^ |
|
@krnowak good idea. As long as |
0814036 to
2fde56a
Compare
|
Depends on #1824 for documentation fixes. |
2fde56a to
1ed56ec
Compare
8e3d9ef to
b5355aa
Compare
|
Rebased. |
Documentation/build-configure.md
Outdated
Documentation/build-configure.md
Outdated
There was a problem hiding this comment.
about the location of the stage1 image
This flag overrides the version used in built stage1 image manifests. Also, when using --with-stage1-default-flavor, the new flag changes the default stage1 version to the overridden one, so rkt will search in the store for an image with the standard coreos name and with an overridden version. This flag is useful for distros serving updated revisions of rkt, like for example in Debian, they might want to put a version 0.12.0-2.
b5355aa to
55ad3b8
Compare
|
Khem, I thought it was merged... Anyway, I updated this branch some time ago. |
|
LGTM |
iaguis
added a commit
that referenced
this pull request
Dec 14, 2015
build: Allow packagers to override stage1 version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813.