Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Conversation

@krnowak
Copy link
Collaborator

@krnowak krnowak commented Jan 7, 2016

Go 1.4.3 tarball by mistake does not provide some tools we require, so
we were go-getting them. Unfortunately go vet recently became broken
for go 1.4, so we revert to go 1.4.2, which had those tools.

Go 1.4.3 tarball by mistake does not provide some tools we require, so
we were go-getting them. Unfortunately go vet recently became broken
for go 1.4, so we revert to go 1.4.2, which had those tools.
@iaguis
Copy link
Member

iaguis commented Jan 7, 2016

LGTM if it works :)

@krnowak krnowak force-pushed the krnowak/downgrade-go14 branch 3 times, most recently from 1b1fe86 to 475c680 Compare January 7, 2016 10:29
@iaguis
Copy link
Member

iaguis commented Jan 7, 2016

Works on Travis and tests compiled on Semaphore. Merging even though TestFetch failed again.

iaguis added a commit that referenced this pull request Jan 7, 2016
travis: Work around problems with go vet on go 1.4
@iaguis iaguis merged commit 8788031 into rkt:master Jan 7, 2016
@jonboulle
Copy link
Contributor

Unfortunately go vet recently became broken for go 1.4,

citation?

On Thu, Jan 7, 2016 at 11:06 AM, Krzesimir Nowak [email protected]
wrote:

Go 1.4.3 tarball by mistake does not provide some tools we require, so
we were go-getting them. Unfortunately go vet recently became broken

for go 1.4, so we revert to go 1.4.2, which had those tools.

You can view, comment on, or merge this pull request online at:

#1941
Commit Summary

  • travis: Work around problems with go vet on go 1.4

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1941.

@jonboulle
Copy link
Contributor

nvm, found it

On Thu, Jan 7, 2016 at 1:00 PM, Jonathan Boulle [email protected]
wrote:

Unfortunately go vet recently became broken for go 1.4,

citation?

On Thu, Jan 7, 2016 at 11:06 AM, Krzesimir Nowak <[email protected]

wrote:

Go 1.4.3 tarball by mistake does not provide some tools we require, so
we were go-getting them. Unfortunately go vet recently became broken

for go 1.4, so we revert to go 1.4.2, which had those tools.

You can view, comment on, or merge this pull request online at:

#1941
Commit Summary

  • travis: Work around problems with go vet on go 1.4

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1941.

@iaguis
Copy link
Member

iaguis commented Jan 7, 2016

For the record:

#1877 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants