Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Conversation

@blixtra
Copy link
Contributor

@blixtra blixtra commented Feb 3, 2016

No description provided.

@blixtra blixtra force-pushed the blixtra/changelog-wrap-pr-numbers-in-parenthasis branch from 70c4537 to 303b40c Compare February 3, 2016 15:57
@iaguis
Copy link
Member

iaguis commented Feb 3, 2016

parenthesis

@iaguis iaguis changed the title CHANGELOG: wrap PR numbers in parenthasis CHANGELOG: wrap PR numbers in parenthesis Feb 3, 2016
@jonboulle
Copy link
Contributor

parentheses

@alban alban added this to the v1.0.0 milestone Feb 3, 2016
@iaguis
Copy link
Member

iaguis commented Feb 3, 2016

parenthesae

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better this way:

Errors are now structured, allowing for better control of the output ([#1937](https://github.com/coreos/rkt/pull/1937)). See [Error & Output](https://github.com/coreos/rkt/blob/master/Documentation/hacking.md#errors--output) for an explanation of how a developer should use it.

@blixtra blixtra force-pushed the blixtra/changelog-wrap-pr-numbers-in-parenthasis branch from 303b40c to 9e98036 Compare February 3, 2016 18:07
@blixtra
Copy link
Contributor Author

blixtra commented Feb 3, 2016

Updated

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/usage/use?

@blixtra blixtra force-pushed the blixtra/changelog-wrap-pr-numbers-in-parenthasis branch from 9e98036 to 89f4637 Compare February 3, 2016 18:25
@alban
Copy link
Member

alban commented Feb 3, 2016

LGTM

alban added a commit that referenced this pull request Feb 3, 2016
…rs-in-parenthasis

CHANGELOG: wrap PR numbers in parenthesis
@alban alban merged commit bc9072d into rkt:master Feb 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants