release v1.3.0 #2355

iaguis · 2016-03-31T16:10:26Z

❗

jonboulle · 2016-03-31T16:12:07Z

CHANGELOG.md

+
+#### Bug fixes
+
+- Propagate exit status from apps inside the pod to rkt ([#2308](https://github.com/coreos/rkt/pull/2308)).


Is this a bug fix? Seems like a kool feature?

Yeah, we were undecided about it being a feature or a bug fix... I think it's a bit of both

I can move it to features, it looks kooler.

iaguis · 2016-03-31T16:22:14Z

Updated.

jonboulle · 2016-03-31T16:23:47Z

CHANGELOG.md

+  - The stage1 image is in the default directory configured at build time
+  - The stage1 image is the default one and it is in the same directory as the rkt binary
+- Allow downloading of insecure public keys with the `pubkey` insecure option ([#2278](https://github.com/coreos/rkt/pull/2278)).
+- Implement Docker volume semantics ([#2315](https://github.com/coreos/rkt/pull/231://github.com/coreos/rkt/pull/2315)). Docker volumes are initialized with the files in the image if they exist, unless a host directory is mounted there. Implement that behavior in rkt when it runs a Docker converted image.


Do we have a doc on this?

Not really, but we print a message when this happens

The link to #2278 is invalid, it does not point to the correct URL

alban · 2016-04-01T09:37:12Z

CHANGELOG.md

+
+#### New features and UX changes
+
+- Propagate exit status from apps inside the pod to rkt ([#2308](https://github.com/coreos/rkt/pull/2308)). Previously, if an app exited with a non-zero exit status, rkt's exit status would still be 0. Now, if an app fails, its exit status will be propagated to the outside.


Since it was already mentioned in v1.1.0's changelog, you could add something like:

This was partially implemented in some stage1 flavors since rkt v1.1.0. This now works in the default coreos flavor.

Good point. Will do.

iaguis · 2016-04-01T09:49:56Z

Updated.

alban · 2016-04-01T10:03:12Z

The patches look good to me. I am running more tests.

alban · 2016-04-01T10:38:22Z

Results of my tests:

all distros:
- FAIL: TestServiceFile TestServiceFile: fails #2323
Fedora 22/23 without SELinux
- no failures (except "all distros")
Fedora Rawhide, with SELinux enabled:
- most tests failed: SELinux on Fedora: rkt started as systemd service: execv() failed: No such file or directory #2322
- when trying again without running tests as a systemd service:
- FAIL: TestVolumes (because of SELinux) SELinux on Fedora: access to host volumes denied #2325
- when disabling SELinux:
- FAIL: TestRktListCreatedStarted TestRktListCreatedStarted fails on slow machines #2220
Ubuntu 15.10
- TestFetch

    rkt_tests.go:214: Error: ExpectRegex didn't find regex 'sha512-[0-9a-f]{32,64}'.
        Output: image: searching for app image coreos.com/etcd
        image: remote fetching from URL "https://github.com/coreos/etcd/releases/download/v2.1.2/etcd-v2.1.2-linux-amd64.aci"
fetch: unexpected EOF=                                         ] 589 KB/5.61 MB  0 B/5.61 MB

Debian 8 (Jessie)
- FAIL: TestAPIServiceCgroup TestAPIServiceCgroup fails on CentOS 7 (systemd-208) #2363
- FAIL: TestRktListCreatedStarted TestRktListCreatedStarted fails on slow machines #2220
CentOS 7:
- FAIL: TestAPIServiceCgroup TestAPIServiceCgroup fails on CentOS 7 (systemd-208) #2363

iaguis · 2016-04-01T13:49:55Z

Rebased.

jonboulle · 2016-04-01T13:52:29Z

Smething about all the dependency bumps?

jonboulle · 2016-04-01T13:52:37Z

surely we picked up some bug fixes, etc in the CNI bump? @steveej

iaguis · 2016-04-01T13:58:06Z

Added something about docker2aci

iaguis · 2016-04-01T14:19:35Z

Let's polish the CHANGELOG later.

alban · 2016-04-01T14:35:11Z

LGTM

iaguis added the kind/release label Mar 31, 2016

jonboulle reviewed Mar 31, 2016
View reviewed changes

iaguis force-pushed the iaguis/release-v1.3.0 branch from 0b6f5a7 to a3dcae3 Compare March 31, 2016 16:21

jonboulle reviewed Mar 31, 2016
View reviewed changes

iaguis force-pushed the iaguis/release-v1.3.0 branch from a3dcae3 to 52e1858 Compare March 31, 2016 16:24

alban reviewed Apr 1, 2016
View reviewed changes

iaguis force-pushed the iaguis/release-v1.3.0 branch from 52e1858 to 2ef4525 Compare April 1, 2016 09:48

jonboulle added this to the v1.3.0 milestone Apr 1, 2016

ROADMAP: update

66ca7ac

iaguis force-pushed the iaguis/release-v1.3.0 branch from 2ef4525 to cf66400 Compare April 1, 2016 13:49

iaguis added 3 commits April 1, 2016 15:57

CHANGELOG: add v1.3.0

03b7de4

version: bump to v1.3.0

97b92aa

version: bump to v1.3.0+git

00e233f

iaguis force-pushed the iaguis/release-v1.3.0 branch from cf66400 to 00e233f Compare April 1, 2016 13:57

iaguis merged commit b6a73a7 into rkt:master Apr 1, 2016

alban assigned iaguis Apr 1, 2016


		#### Bug fixes

		- Propagate exit status from apps inside the pod to rkt ([#2308](https://github.com/coreos/rkt/pull/2308)).


		#### New features and UX changes

		- Propagate exit status from apps inside the pod to rkt ([#2308](https://github.com/coreos/rkt/pull/2308)). Previously, if an app exited with a non-zero exit status, rkt's exit status would still be 0. Now, if an app fails, its exit status will be propagated to the outside.

Uh oh!

release v1.3.0 #2355

release v1.3.0 #2355

Uh oh!

Conversation

iaguis commented Mar 31, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iaguis commented Mar 31, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iaguis commented Apr 1, 2016

Uh oh!

alban commented Apr 1, 2016

Uh oh!

alban commented Apr 1, 2016

Uh oh!

iaguis commented Apr 1, 2016

Uh oh!

jonboulle commented Apr 1, 2016

Uh oh!

jonboulle commented Apr 1, 2016

Uh oh!

iaguis commented Apr 1, 2016

Uh oh!

iaguis commented Apr 1, 2016

Uh oh!

alban commented Apr 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants