This repository was archived by the owner on Feb 24, 2020. It is now read-only.
store: fix comment + add link in db test #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO(sgotti) this will not find concurrent accesses to ql db from | ||
| // multiple processes using multiple goroutines. A test that spawns at | ||
| // least two processes using multiple goroutines is needed. | ||
| // See https://github.com/coreos/rkt/pull/2391 |
There was a problem hiding this comment.
Should you link to the specific comment?
#2391 (comment)
There was a problem hiding this comment.
I don't think so, he updated the OP and the entire discussion is useful IMHO
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.