This repository was archived by the owner on Feb 24, 2020. It is now read-only.
*.*: Updated docs/tests for 'rkt gc --mark-only' #2429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ExecStartPre=/usr/bin/rkt fetch myapp.com/myapp-1.3.4 | ||
| # Start the app | ||
| ExecStart=/usr/bin/rkt run --inherit-env --port=http:8888 myapp.com/myapp-1.3.4 | ||
| ExecStop=/usr/bin/rkt gc --mark-only |
There was a problem hiding this comment.
Does it really work? According to the documentation, ExecStop is executed to stop the service (when the user runs systemctl stop ...), not after the rkt command terminates.
https://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStop=
ExecStopPost could work instead.
There was a problem hiding this comment.
@alban That's a better idea. Thank you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2425
Fix #2420
Fix #2400 (comment)
cc @alban @iaguis @jonboulle