This repository was archived by the owner on Feb 24, 2020. It is now read-only.
kvm/qemu: add extra kernel parameters #3644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, CI had been broken due to the switch to a different org. It seems to have been properly picked-up now. |
|
@alban would you mind rebasing on current master? It should help on the testing side. @jellonek @grahamwhaley I think I can just carry on your previous LGTMs to here. |
|
Yep, a cursory glance looks like it is the same as before, so |
For testing purpose, I need to add extra kernel parameters in the VM. Implemented in this way: sudo RKT_HYPERVISOR_EXTRA_KERNEL_PARAMS="foo1=bar foo2=bar" \ ./build-rkt-1.21.0+git/target/bin/rkt run \ --stage1-path=$PWD/build-rkt-1.21.0+git/target/bin/stage1-kvm.aci \ --insecure-options=image --interactive \ docker://busybox --cpu 1 --exec sh -- -c \ 'cat /proc/cmdline' noapic noacpi pci=conf1 reboot=k panic=1 i8042.direct=1 i8042.dumbkbd=1 i8042.nopnp=1 console=ttyS0 i8042.noaux=1 rw rootflags=trans=virtio,version=9p2000.L,cache=mmap rootfstype=9p systemd.default_standard_error=journal+console systemd.default_standard_output=journal+console systemd.machine_id=3a2af63d415946778491bda1cb828c57 console=hvc0 init=/usr/lib/systemd/systemd no_timer_check noreplace-smp tsc=reliable systemd.show_status=false systemd.log_target=null rd.udev.log-priority=3 quiet=vga quiet systemd.log_level=emerg foo1=bar foo2=bar
f03226c to
0a4eac9
Compare
|
Rebased and force-pushed. There was no conflicts. |
lucab
approved these changes
May 9, 2017
There was a problem hiding this comment.
Capturing two previous LGTMs from @jellonek and @grahamwhaley.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3622: I am doing a new PR because the CI seems broken.
For testing purpose, I need to add extra kernel parameters in the VM.
Implemented in this way:
sudo RKT_HYPERVISOR_EXTRA_KERNEL_PARAMS="foo1=bar foo2=bar"
./build-rkt-1.21.0+git/target/bin/rkt run
--stage1-path=$PWD/build-rkt-1.21.0+git/target/bin/stage1-kvm.aci
--insecure-options=image --interactive
docker://busybox --cpu 1 --exec sh -- -c
'cat /proc/cmdline'
noapic noacpi pci=conf1 reboot=k panic=1 i8042.direct=1 i8042.dumbkbd=1 i8042.nopnp=1 console=ttyS0 i8042.noaux=1 rw rootflags=trans=virtio,version=9p2000.L,cache=mmap rootfstype=9p systemd.default_standard_error=journal+console systemd.default_standard_output=journal+console systemd.machine_id=3a2af63d415946778491bda1cb828c57 console=hvc0 init=/usr/lib/systemd/systemd no_timer_check noreplace-smp tsc=reliable systemd.show_status=false systemd.log_target=null rd.udev.log-priority=3 quiet=vga quiet systemd.log_level=emerg foo1=bar foo2=bar
We'll need this for https://github.com/kinvolk/stage1-builder
/cc @schu