This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1: support hybrid cgroup hierarchy #3784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd introduced the hybrid cgroup hierarchy that mounts a cgroup v1 and v2 hierarchy in parallel. After systemd v233 the cgroup v2 hierarchy is mounted in `/sys/fs/cgroup/unified`. This breaks rkt (specifically flavor host) because we mount `/sys/fs/cgroup` ourselves and were not creating the `unified` directory. Let's create `/sys/fs/cgroup/unified` in CreateCgroup() to support the hybrid cgroup hierarchy. If the system or stage1 doesn't use the hybrid hierarchy, having this directory created doesn't hurt.
Member
Author
|
I tried other implementations before deciding to submit this one, you can read them in git history form here: https://github.com/kinvolk/rkt/commits/iaguis/hybrid-hierarchy-story |
Member
|
@iaguis It looks good but...
This double usage already non-trivial error management when mounting sysfs. And this new |
Member
Author
|
I thought about that and we could create the dir only if However, note that we're creating the directory in a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd introduced the hybrid cgroup hierarchy that mounts a cgroup v1
and v2 hierarchy in parallel. After systemd v233 the cgroup v2 hierarchy
is mounted in
/sys/fs/cgroup/unified. This breaks rkt (specificallyflavor host) because we mount
/sys/fs/cgroupourselves and were notcreating the
unifieddirectory.Let's create
/sys/fs/cgroup/unifiedinCreateCgroup()to support thehybrid cgroup hierarchy. If the host system (or the stage1) doesn't use
the hybrid hierarchy, having this directory created doesn't hurt.
Fixes #3741