This repository was archived by the owner on Feb 24, 2020. It is now read-only.
rkt: skip parsing in case of an empty string #3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e022d5c to
53a85cf
Compare
When any string in []args is empty, "", then the `al.Count()` gets still incremented, even if there's nothing to parse. As a result, `rkt app add` fails with an error message like `must give only one app`, even when only one app name is given. For example, rktlet runs the following command: ``` rkt app --insecure-options=image,ondisk add 58992c0a-540d-40a4-bf39-4bb193d74f94 \ docker://busybox:1.26 --name=2-seccomp-container-docker-default-d25eafce-ad02-11e7-a670-2eecc98c9398d25eaff2-ad02-11e7-a670-2eecc98c9398 \ --user-annotation=k8s.io/reserved/image-name=busybox:1.26 --exec=top ``` Then the last part, " --exec=top" is parsed a list of 2 separate strings: " " and "--exec=top", That's why `al.Count()` becomes 2. See also kubernetes-retired/rktlet#146 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any string in
[]argsis empty,"", then theal.Count()gets still incremented, even if there's nothing to parse. As a result,rkt app addfails with an error message likemust give only one app, even when only one app name is given.For example, rktlet runs the following command:
Then the last part,
" --exec=top"is parsed to a list of 2 separate strings:" "and"--exec=top", That's whyal.Count()becomes 2.See also kubernetes-retired/rktlet#146 (comment)