This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1-fly/run: allow non absolute commands to be run #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the contribution! This works fine for most cases. However it doesn't follow the spec in the following case:
You could check yourself for that case but luckily, we have a function that we use currently for the container flavors that does exactly what we want here. It's in FindBinPath(). Also, it's nice to be using code that's already being used in the container flavors. |
changes stage1-fly to convert a command name into an absolute path so that syscall.Exec is able to properly execute it.
Contributor
Author
|
Hi, fixed it up again. @iaguis PTAL! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes stage1-fly to convert a command name into an absolute path so
that syscall.Exec is able to properly execute it.
solves #3662.
@jyouchan and I worked on this together.