Avoid type alias in trait impl #604
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discord's discussion: https://discordapp.com/channels/822925794249539645/1356558336752877679/1357009874730356747
Transcript
taintegral:With a macro expansion, it looks like this is caused by the use of type alises in trait impls. This impl triggers the lint:
but this one doesn't
(note the exchange of ::rkyv::Archived<Matrix<T, R, C>> for ArchivedMatrix<T, R, C>)
I thought we got rid of all of the uses of type alises in trait impls, but I guess I imagined that. If you want to do that change, I'd be happy to review/merge.
TL;DR
Deserializemacro fails at surprising setups, due to type alias being used.Current status
See comments