Fix bug of __getitem__() in ExtendedTimeStep #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MishaLaskin. Thanks for sharing your code@ I have found a bug when running the pertaining script.
At the line 49
value = time_step[spec.name]inreplay_buffer.py, we have an error thatreturn getattr(self, attr)at the line 30 indmc.pywill be called twice. This leads to an error where the second call will take as input attribute an int-type attr. It is not so clear about the exact reason for this issue, but I guess it may come from the inheritance of classExtendedTimeStep. It can be solved by deleting such inheritance and writing an explicit__init__()function. Hope it helps:)