Update RNMapboxMapsVersion in install.md#4070
Closed
dwightwatson wants to merge 1 commit intornmapbox:mainfrom
Closed
Update RNMapboxMapsVersion in install.md#4070dwightwatson wants to merge 1 commit intornmapbox:mainfrom
dwightwatson wants to merge 1 commit intornmapbox:mainfrom
Conversation
Updated RNMapboxMapsVersion to 11.15.0 and added version review links.
mfazekas
reviewed
Nov 7, 2025
| "@rnmapbox/maps", | ||
| { | ||
| "RNMapboxMapsVersion": "11.13.4" | ||
| "RNMapboxMapsVersion": "11.15.0" |
Contributor
There was a problem hiding this comment.
RNMapboxMapsVersion is not a mandatory parameter AFAIK. So maybe we should put to an advanced section.
Or maybe just point to https://rnmapbox.github.io/ here.
Author
|
I suppose not. I first tried to just use the plugin as a string When I left the options as an empty object it seemed to work. A little unexpected but I can update the PR to match if you like. ["@rnmapbox/maps", {}], |
mfazekas
pushed a commit
that referenced
this pull request
Nov 8, 2025
Users can now use the plugin without providing options:
- ["@rnmapbox/maps"] instead of requiring ["@rnmapbox/maps", {}]
Previously, all ConfigPlugin functions destructured the options parameter
without default values, causing "Cannot destructure property 'RNMapboxMapsImpl'
of 'undefined'" errors when options were not provided.
This change adds default empty object values (= {}) to all function parameters
that destructure MapboxPlugProps, making all options truly optional as intended.
Fixes #4070
mfazekas
pushed a commit
that referenced
this pull request
Nov 8, 2025
Users can now use the plugin without providing options:
- ["@rnmapbox/maps"] instead of requiring ["@rnmapbox/maps", {}]
Previously, all ConfigPlugin functions destructured the options parameter
without default values, causing "Cannot destructure property 'RNMapboxMapsImpl'
of 'undefined'" errors when options were not provided.
This change adds default empty object values (= {}) with explicit MapboxPlugProps
type annotations to all function parameters that destructure MapboxPlugProps,
making all options truly optional as intended.
Changes:
- Updated all ConfigPlugin functions to use typed default parameters
- Rebuilt plugin JavaScript files with the fix
Fixes #4070
mfazekas
pushed a commit
that referenced
this pull request
Nov 8, 2025
Users can now use the plugin without providing options:
- ["@rnmapbox/maps"] instead of requiring ["@rnmapbox/maps", {}]
Previously, all ConfigPlugin functions destructured the options parameter
without default values, causing "Cannot destructure property 'RNMapboxMapsImpl'
of 'undefined'" errors when options were not provided.
This change adds default empty object values (= {}) with explicit MapboxPlugProps
type annotations to all function parameters that destructure MapboxPlugProps,
making all options truly optional as intended.
Changes:
- Updated all ConfigPlugin functions to use typed default parameters
- Rebuilt plugin JavaScript files with the fix
Fixes #4070
mfazekas
pushed a commit
that referenced
this pull request
Nov 8, 2025
Users can now use the plugin without providing options:
- ["@rnmapbox/maps"] instead of requiring ["@rnmapbox/maps", {}]
Previously, all ConfigPlugin functions destructured the options parameter
without default values, causing "Cannot destructure property 'RNMapboxMapsImpl'
of 'undefined'" errors when options were not provided.
This change adds default empty object values (= {}) with explicit MapboxPlugProps
type annotations to all function parameters that destructure MapboxPlugProps,
making all options truly optional as intended.
Changes:
- Updated all ConfigPlugin functions to use typed default parameters
- Rebuilt plugin JavaScript files with the fix
Fixes #4070
mfazekas
pushed a commit
that referenced
this pull request
Nov 8, 2025
Users can now use the plugin without providing options:
- ["@rnmapbox/maps"] instead of requiring ["@rnmapbox/maps", {}]
Previously, all ConfigPlugin functions destructured the options parameter
without default values, causing "Cannot destructure property 'RNMapboxMapsImpl'
of 'undefined'" errors when options were not provided.
This change adds default empty object values (= {}) with explicit MapboxPlugProps
type annotations to all function parameters that destructure MapboxPlugProps,
making all options truly optional as intended.
Changes:
- Updated all ConfigPlugin functions to use typed default parameters
- Rebuilt plugin JavaScript files with the fix
Fixes #4070
Contributor
|
@dwightwatson So I've fixed the issue, now the plugin should work with just |
Author
|
Thanks - appreciate that. I noticed the new version and upgraded already... much simpler! |
Contributor
|
Closing this as I think it's outdated now. Feel free to open a new doc pr if there is still something needs clarification |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #4069
I too ran into a build issue when trying to upgrade and migrate towards using the download token as an environment variable. The version in the docs won't build for Expo - so I've updated it to a version that works (see the related issue) and linked to where users can see the current available versions.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)