Fix local-workflow-tech.md #745
Conversation
Setting the variable before the command does not seem to work. I quickly checked on Ubuntu and
```
var=5 echo ${var}
```
outputs empty, while
```
var=5
echo ${var}
```
outputs `5` as expected even without `export`
There was a problem hiding this comment.
Summary of Changes
Hello @S-Dafarra, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a minor but important fix to the project's documentation, specifically within the local-workflow-tech.md file. The change ensures that the instructions for configuring Git with a Personal Access Token (PAT) are technically accurate and functional, preventing potential user confusion or errors related to shell variable assignment.
Highlights
- Documentation Correction: Corrected a shell command example in
.github/local-workflow-tech.mdto accurately demonstrate how to set and use an environment variable (PAT) by ensuring the variable assignment and its usage are on separate lines. This addresses a common shell scripting nuance whereVAR=value commanddoes not persistVARfor subsequent commands in the same way asVAR=value\ncommand.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request addresses an issue where setting a variable before a command in a shell script doesn't work as expected. The change introduces a newline to separate the variable assignment and the git command. I suggested combining the commands on a single line using && to ensure the variable is set before the command executes.
Setting the variable before the command does not seem to work. I quickly checked on Ubuntu and
outputs empty, while
outputs
5as expected even withoutexport