fix jwt in native app for qewd up. #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix where qewd up would not allow jwt support even if we add jwt in config.json.
|
@faisalsami looks broken? |
|
I'm not going to make the suggested changes for two reasons: 1) I'm concerned that the CORS-related changes to Express headers and socket-io configuration could/may have negative consequences for other users; and 2) the versions of some of the modules you've made changes to are out of date compared with the QEWD Master version. I think the way to handle 1) would be to provide additional configuration settings via the config.json file and then conditionalise the code you suggest to use those specific configuration changes |
|
Hi Rob, Sorry the new commit related to cors changes is accidently done. I
was committing my public/private code present on my old laptop to make it
available on the new laptop and accidentally committed the cors changes
that I was just playing around with cors functions. The suggested changes
were only for jwt for native apps.
Regards,
Faisal
…On Tue, Oct 26, 2021 at 1:31 PM robtweed ***@***.***> wrote:
I'm not going to make the suggested changes for two reasons: 1) I'm
concerned that the CORS-related changes to Express headers and socket-io
configuration could/may have negative consequences for other users; and 2)
the versions of some of the modules you've made changes to are out of date
compared with the QEWD Master version. I think the way to handle 1) would
be to provide additional configuration settings via the config.json file
and then conditionalise the code you suggest to use those specific
configuration changes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMJQUSUABMMRTLMA2HYCTUIZYOFANCNFSM4IOTIX3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix where qewd up would not allow jwt support even if we add jwt in config.json file in case of native app .