✅ Deploy Preview for viseron canceled.

If you want to check out the docs you can either use the Preview link created by Netlify or you can run the docs locally

Thanks for the comments I will update the PR.

CI is failing due to the hosted agent running out of space when installing ultralytics and all the deps. Investigating

If you want to check out the docs you can either use the Preview link created by Netlify or you can run the docs locally

Thanks.

Where do I place the image for the component browser entry? I have /img/Ultralytics_YOLO_Logomark_Original.svg as the link but could not determine where to put it,

I forgot to mention that the version of the Ultralytics library I referenced doesn't have type hints. This is probably a the cause of failure of the mypy pre-commit check. For my workflow I need to use a couple of machines and the one I submit code doesn't have the pre-commit checks enabled so that is how it got submitted without passing.

I see in the last week there was an update that has type annotations in the library. I have not tested yet but can hold off on PR until that has been verified.

error:

viseron/components/yolo/object_detector.py:7: error: Skipping analyzing "ultralytics": module is installed, but missing library stubs or py.typed marker  [import-untyped]
viseron/components/yolo/object_detector.py:7: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)

If you want to check out the docs you can either use the Preview link created by Netlify or you can run the docs locally

Thanks.

Where do I place the image for the component browser entry? I have /img/Ultralytics_YOLO_Logomark_Original.svg as the link but could not determine where to put it,

Where did you find it? One option is to find a link to a hosted version and use that instead of commiting it to the repo

I forgot to mention that the version of the Ultralytics library I referenced doesn't have type hints. This is probably a the cause of failure of the mypy pre-commit check. For my workflow I need to use a couple of machines and the one I submit code doesn't have the pre-commit checks enabled so that is how it got submitted without passing.

I see in the last week there was an update that has type annotations in the library. I have not tested yet but can hold off on PR until that has been verified.

error:

viseron/components/yolo/object_detector.py:7: error: Skipping analyzing "ultralytics": module is installed, but missing library stubs or py.typed marker  [import-untyped]
viseron/components/yolo/object_detector.py:7: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)

I made some changes which should increase disk space available on the agent.
Can you rebase off of dev and push again?

Where did you find it? One option is to find a link to a hosted version and use that instead of commiting it to the repo

It was in a zip file I downloaded from here. However, on that page there is a preview image with a link to a svg on CDN. I will change to that.

I made some changes which should increase disk space available on the agent.
Can you rebase off of dev and push again?

I should re-squash into a new branch? Or should I leave the commits in existing branch?

I made some changes which should increase disk space available on the agent.
Can you rebase off of dev and push again?

I should re-squash into a new branch? Or should I leave the commits in existing branch?

That is up to you! You either merge dev into your branch or rebase and force push.
You don't need to make a new branch.

Edit: ah I see you did that already. Will start the CI

Hmm i cant get the CI to work. Need some more time to investigate

Now its working again, two small issues tho, would you mind trying to fix them?

Pylint error should be easy.

And i think the mypy error can be fixed by adding this to .mypy.ini:

[mypy-ultralytics.*]
ignore_missing_imports = True

I will make that changes

Done and pushed.

Pylint is still complaining, but i can fix that for you if you like. I have pestered you enough already 😄

I will fix that. It is in an additional file that is not part of this change but it looks pretty benign. Should take a minute or two.

Also note that that the tests I added will take 10 seconds each or so to run and are not quick like other tests. They wait for the concatenate thread to finish in order to validate the timing aspects of the change. If this is a concern maybe these can be conditionally in some way (e.g. do not run locally).

Awesome, great job! And thanks for sticking with it all the way :)

No problem and thanks for this great application. I could not have done any of this without all the hooks and interfaces you put in place.

Oh...I just updated to this version and so far it works as expected :)

Great! 🚀