Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conditionally add HTTPS inbound allow firewall rule #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swalkinshaw merged 2 commits into from
Aug 18, 2024
Merged

Conditionally add HTTPS inbound allow firewall rule #1530

swalkinshaw merged 2 commits into from
Aug 18, 2024

Conversation

@strarsis
Copy link
Contributor

@strarsis strarsis commented Jul 29, 2024

This PR lets the firewall rule to allow inbound HTTPS to be added conditionally.
Only when at least one site uses HTTPS, the firewall rule for allowing inbound HTTPS is added.

swalkinshaw
swalkinshaw reviewed Jul 29, 2024
View reviewed changes
@strarsis
Use already existing sites_use_ssl variable.
cf5fedb 
Use `delete` parameter for toggling https firewall allow rule.
@strarsis
Copy link
Contributor Author

strarsis commented Jul 29, 2024 •
edited
Loading

Edit: Using the delete attribute as this allows toggling and proper clean up of file when HTTPS firewall allow rule is not needed (in subsequent provisions), it also allows for much simpler configuration code.
The not inverts the fact that SSL is used, as it is used with delete which does the opposite of enabling the rule.

This was referenced Jul 29, 2024
Open
Closed
@swalkinshaw swalkinshaw merged commit 1e505b3 into roots:master Aug 18, 2024
@swalkinshaw
Copy link
Member

swalkinshaw commented Aug 18, 2024

Thanks @strarsis

@mathiasoem mathiasoem mentioned this pull request Aug 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swalkinshaw swalkinshaw swalkinshaw left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strarsis @swalkinshaw