Fix HSTS header omitted parts #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None seems to be replaced by an empty string by ansible. This can result in the Strict-Transport-Security header with a value like "max-age=1234; ; " or "max-age=1234; includeSubdomains; " Follow the ansible playbook guide example for omitting items from a list using the special omit variable.
swalkinshaw
approved these changes
Aug 15, 2025
Member
swalkinshaw
left a comment
There was a problem hiding this comment.
Verified this locally. Thanks 👍
│ TASK [Test with None] ********************************************************** │
│ ok: [localhost] => { │
│ "msg": "add_header Strict-Transport-Security \"max-age=1234; ;\";" │
│ } │
│ │
│ TASK [Test with omit] ********************************************************** │
│ ok: [localhost] => { │
│ "msg": "add_header Strict-Transport-Security \"max-age=1234\";" │
│ } │
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneseems to be replaced by an empty string by ansible. This can result in theStrict-Transport-Securityheader with a value like"max-age=1234; ; "or"max-age=1234; includeSubdomains; "Follow the ansible playbook guide example for omitting items from a list using the special
omitvariable. This removes extra;from the header.