Resolve import.meta.{filename,dirname} in files imported from config#5520
Merged
lukastaegert merged 1 commit intorollup:masterfrom May 22, 2024
Merged
Resolve import.meta.{filename,dirname} in files imported from config#5520lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
…ranspiled config files
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5520 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 238 238
Lines 9540 9544 +4
Branches 2437 2439 +2
=======================================
+ Hits 9427 9431 +4
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
lukastaegert
approved these changes
May 22, 2024
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
|
This PR has been released as part of [email protected]. You can test it via |
This was referenced Jun 13, 2024
This was referenced Jun 19, 2024
This was referenced Jun 20, 2024
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
This was referenced Sep 25, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: N/A
Description
Back in #4005, rollup was taught how to resolve
import.meta.urlin files imported into the rollup config using a relative path - makingimport.meta.urlrefer the file it's used in, rather than the config file.node 20.11.0 introduced two new import meta fields -
import.meta.filenameandimport.meta.dirname- that act the same as __filename and __dirname in commonjs.This PR teaches rollup config transpilation how to transform
import.meta.filenameandimport.meta.dirnameso they behave as expected inside plugins that are imported via relative paths. Previously, import.meta.filename and import.meta.dirname would be the file/directory of the config file.