Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: set sourcesContent to undefined instead of null when excluding sources content #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukastaegert merged 1 commit into from
Dec 16, 2025
Merged

fix: set sourcesContent to undefined instead of null when excluding sources content #6196

lukastaegert merged 1 commit into from
Dec 16, 2025
+15 −15

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Nov 29, 2025 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #6191

Description

@vercel
Copy link

vercel bot commented Nov 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
rollup Ready Ready Preview, Comment Dec 15, 2025 2:58pm

@github-actions
Copy link

github-actions bot commented Nov 29, 2025 •
edited
Loading

Performance report

  • BUILD: 7235ms, 823 MB
    • initialize: 0ms, 24.6 MB (+7%)
    • generate module graph: 2674ms, 628 MB
      • generate ast: 1388ms, 620 MB
    • sort and bind modules: 411ms, 686 MB
    • mark included statements: 4090ms, 823 MB
      • treeshaking pass 1: 2440ms, 819 MB
      • treeshaking pass 2: 466ms, 839 MB (+5%)
      • treeshaking pass 3: 399ms, 824 MB
      • treeshaking pass 4: 383ms, 844 MB (+5%)
      • treeshaking pass 5: 383ms, 823 MB
  • GENERATE: 698ms, 922 MB (+3%)
    • initialize render: 0ms, 823 MB
    • generate chunks: 50ms, 844 MB (+5%)
      • optimize chunks: 0ms, 838 MB (+3%)
    • render chunks: 631ms, 896 MB (+3%)
    • transform chunks: 18ms, 922 MB (+3%)
    • generate bundle: 0ms, 922 MB (+3%)

@github-actions
Copy link

github-actions bot commented Nov 29, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/6192

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-nmr9xpjkr-rollup-js.vercel.app/repl/?pr=6196

@codecov
Copy link

codecov bot commented Nov 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (7df7947) to head (19e64fa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6196   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         271      271           
  Lines       10660    10660           
  Branches     2852     2852           
=======================================
  Hits        10526    10526           
  Misses         91       91           
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lukastaegert
lukastaegert approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the tests, it looks as it should, thanks!

@lukastaegert lukastaegert added this pull request to the merge queue Dec 16, 2025
Merged via the queue into master with commit d761365 Dec 16, 2025
45 checks passed
@lukastaegert lukastaegert deleted the fix/6192 branch December 16, 2025 05:24
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Dec 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting sourcemapExcludeSources to true generates invalid sourcemap

3 participants

@TrickyPi @lukastaegert