Make sure cli entry points with the same name but on different paths are deconflicted#2548
Merged
lukastaegert merged 1 commit intomasterfrom Nov 11, 2018
Merged
Conversation
are deconflicted (unless explicit naming via "=" is used in some of them)
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2543
Description
The special logic for naming entry points via the CLI by using "=" in the name always kicked in regardless if "=" was used or not. This lead to entry points overwriting each other. This PR only uses this naming logic in case at least one input uses "="