Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make sure cli entry points with the same name but on different paths are deconflicted#2548

Merged
lukastaegert merged 1 commit intomasterfrom
deconflict-cli-entry-points
Nov 11, 2018
Merged

Make sure cli entry points with the same name but on different paths are deconflicted#2548
lukastaegert merged 1 commit intomasterfrom
deconflict-cli-entry-points

Conversation

@lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2543

Description

The special logic for naming entry points via the CLI by using "=" in the name always kicked in regardless if "=" was used or not. This lead to entry points overwriting each other. This PR only uses this naming logic in case at least one input uses "="

are deconflicted (unless explicit naming via "=" is used in some of them)
@lukastaegert lukastaegert merged commit 0e065d0 into master Nov 11, 2018
@lukastaegert lukastaegert deleted the deconflict-cli-entry-points branch November 11, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing entry points when using --input command line flag, --dir, and experimentalCodeSplitting when entry point filenames collide

1 participant