Fix crash when returning undefined sourcemaps from renderChunk hook#2558
Merged
lukastaegert merged 1 commit intorollup:masterfrom Nov 17, 2018
Merged
Fix crash when returning undefined sourcemaps from renderChunk hook#2558lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
lukastaegert
approved these changes
Nov 17, 2018
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Awesome fix, thanks a lot!
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#2557
Description
Fixes #2557.
Previously, if source maps were enabled and a renderChunk hook returned just the transformed code (i.e., an
undefinedsource map), Rollup would throw an error -- this was becauseundefinedsource maps are replaced with a placeholder object, used to signal that the source map is missing, and which plugin generated it. These objects were not being detected everywhere, so they would sometimes be used as source maps when they should not be.This fixes the issue by reusing an existing block of code to detect these placeholder objects, issue a warning, and replace them with an empty source map.