Fix sourcemaps for large minified bundles#2571
Merged
lukastaegert merged 1 commit intorollup:masterfrom Dec 3, 2018
Merged
Conversation
Sourcemaps were broken for lines longer than 32767 characters, which can happen if a large bundle was generated and minifed using Rollup. Rich-Harris/sourcemap-codec#77 Regressed in v0.66.3 8a8721e
|
Please merge this PR. It fixes issue where source maps are not generated correctly. This defect was initially caused by my PR to sourcemap-codec to speed it up. But int16 cannot hold enough information when bundle sizes are large. Rich-Harris/sourcemap-codec@5d0d168 Please merge and release new version to npm. |
lukastaegert
approved these changes
Dec 3, 2018
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
Member
|
Published as 0.67.4 |
lukastaegert
pushed a commit
that referenced
this pull request
Dec 7, 2018
Sourcemaps were broken for lines longer than 32767 characters, which can happen if a large bundle was generated and minifed using Rollup. Rich-Harris/sourcemap-codec#77 Regressed in v0.66.3 8a8721e
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Sourcemaps were broken for lines longer than 32767 characters, which can happen if a large bundle was generated and minifed using Rollup.
Rich-Harris/sourcemap-codec#77
Regressed in v0.66.3 8a8721e