Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added missing CI workflow for v3.x #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2023
Merged

Added missing CI workflow for v3.x #616

merged 1 commit into from
Apr 14, 2023

Conversation

@danielmorell
Copy link
Collaborator

@danielmorell danielmorell commented Apr 12, 2023

Description of the change

Added a GitHub Action workflow file to run tests against any changes to our v3 branch next/3.x/main.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Apr 12, 2023
waltjones
waltjones approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

waltjones
waltjones reviewed Apr 12, 2023
View reviewed changes
.github/workflows/ci-3.x.yml
- next/3.x/**
schedule:
# Every day at 02:42
- cron: '42 2 * * *'
Copy link
Contributor

@waltjones waltjones Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky number?

@danielmorell danielmorell merged commit d02c2a1 into master Apr 14, 2023
@danielmorell danielmorell deleted the added/ci-for-v3-branch branch April 14, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waltjones waltjones waltjones approved these changes

@cyrusradfar cyrusradfar Awaiting requested review from cyrusradfar

Assignees

No one assigned

Labels

Type: Maintenance General up-keep, or changes that tidy an existing component or process.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielmorell @waltjones