Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(watch): only consider files read from disk are able to watch #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

fix(watch): only consider files read from disk are able to watch #6037

merged 1 commit into from
Sep 8, 2025

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 7, 2025

No description provided.

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review September 7, 2025 08:20
@netlify
Copy link

netlify bot commented Sep 7, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0a3140a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68bd40de4042f500089ad53a

graphite-app[bot]
graphite-app bot reviewed Sep 7, 2025
View reviewed changes
@hyf0 hyf0 force-pushed the 09-07-fix_watch_only_considere_files_read_from_disk_are_able_to_watch branch from 5f7aaf0 to 0a3140a Compare September 7, 2025 08:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2025

Benchmarks Rust

  • target: main(9223b9c)
  • pr: 09-07-fix_watch_only_considere_files_read_from_disk_are_able_to_watch(0a3140a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     89.3±2.65ms        ? ?/sec    1.00     88.5±2.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     99.5±2.96ms        ? ?/sec    1.00     99.4±3.97ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    126.0±2.56ms        ? ?/sec    1.00    126.5±2.48ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    149.0±3.72ms        ? ?/sec    1.00    146.5±2.34ms        ? ?/sec
bundle/bundle@threejs                                        1.00     47.1±1.42ms        ? ?/sec    1.02     48.0±2.87ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     56.2±2.44ms        ? ?/sec    1.00     55.7±1.07ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    490.2±5.79ms        ? ?/sec    1.00    491.7±6.77ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    574.6±6.17ms        ? ?/sec    1.00    575.4±6.14ms        ? ?/sec
scan/scan@rome_ts                                            1.01    103.0±2.19ms        ? ?/sec    1.00    102.1±2.83ms        ? ?/sec
scan/scan@threejs                                            1.00     37.1±2.38ms        ? ?/sec    1.00     37.1±2.13ms        ? ?/sec
scan/scan@threejs10x                                         1.01    371.5±5.61ms        ? ?/sec    1.00    367.5±8.71ms        ? ?/sec

@sapphi-red sapphi-red changed the title fix(watch): only considere files read from disk are able to watch fix(watch): only consider files read from disk are able to watch Sep 8, 2025
sapphi-red
sapphi-red approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add tests that ensures:

  • ids loaded via load hook is not watched
  • ids loaded by the file read is watched
  • ids added via addWatchFile is watched

@sapphi-red sapphi-red added this pull request to the merge queue Sep 8, 2025
@hyf0
Copy link
Member Author

hyf0 commented Sep 8, 2025

I think we should add tests that ensures:

  • ids loaded via load hook is not watched
  • ids loaded by the file read is watched
  • ids added via addWatchFile is watched

We should do that.

I think the thrid one already has tests. Others, emm, I don't want to touch watch related code if possible at current stage :). It requires too much efforts to understand it.

@hyf0 hyf0 mentioned this pull request Sep 8, 2025
Open
Merged via the queue into main with commit 2d556fe Sep 8, 2025
28 checks passed
@sapphi-red sapphi-red deleted the 09-07-fix_watch_only_considere_files_read_from_disk_are_able_to_watch branch September 8, 2025 02:03
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Merged
shulaoda added a commit that referenced this pull request Sep 8, 2025
@github-actions @shulaoda
release: v1.0.0-beta.36 (#6068)
03b7b72 
## [1.0.0-beta.36] - 2025-09-08
> [!warning]
> ### 💥 BREAKING CHANGES
> 
> - drop CJS format, increase minimum required node (#6025) by @sxzz


### 🚀 Features

- rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda
- rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda
- rolldown: oxc v0.87.0 (#5975) by @Boshen

### 🐛 Bug Fixes

- allow keeping whitespace while enabling minify (#5893) by @sapphi-red
- dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0
- validator of `output.minify` (#6062) by @IWANABETHATGUY
- codspeed rust benchmark ci (#6052) by @IWANABETHATGUY
- just command in ci (#6045) by @IWANABETHATGUY
- watch: only consider files read from disk are able to watch (#6037) by @hyf0

### 🚜 Refactor

- dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0
- unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda

### 🧪 Testing

- rust: ensure unused pure function call got treeshaked (#4524) by @hyf0
- hmr: tweak improper test (#6034) by @hyf0
- hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0
- hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6003) by @renovate[bot]
- deps: lock file maintenance npm packages (#5995) by @renovate[bot]
- add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY
- fix benchmark-node workflow (#6060) by @IWANABETHATGUY
- adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY
- just commands in ci (#6056) by @IWANABETHATGUY
- run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY
- remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY
- remove auto approval ci (#6051) by @IWANABETHATGUY
- adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY
- repo: check format/style in `just lint-rust` (#6050) by @hyf0
- repo/ai: refine `justfile` (#6038) by @hyf0
- repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0
- deps: update github-actions (major) (#6041) by @renovate[bot]
- deps: update github-actions (#6040) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot]

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

@sapphi-red sapphi-red

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyf0 @sapphi-red