• refactor(rolldown_error): remove unused EventKind::IoError #6134
• chore(rolldown_error): remove unnecessary type_aliases.rs #6133
• feat: improve bundler initialization error handling #6132 👈 (View in Graphite)
• main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	4ba0c62
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68c2352b24a06e000843626f
😎 Deploy Preview	https://deploy-preview-6132--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Probably this could be merged into

Probably this could be merged into

rolldown/crates/rolldown_error/src/events/invalid_option.rs

Lines 1 to 45 in d93212f

	use crate::events::BuildEvent;
	use crate::{DiagnosticOptions, EventKind};
	#[derive(Debug)]
	pub enum InvalidOptionType {
	UnsupportedInlineDynamicFormat(String),
	UnsupportedCodeSplittingFormat(String),
	InvalidOutputFile,
	InvalidOutputDirOption,
	NoEntryPoint,
	AdvancedChunksWithoutGroups(Vec<String>),
	InvalidContext(String),
	}
	#[derive(Debug)]
	pub struct InvalidOption {
	pub invalid_option_type: InvalidOptionType,
	}
	impl BuildEvent for InvalidOption {
	fn kind(&self) -> EventKind {
	EventKind::InvalidOptionError
	}
	fn message(&self, _opts: &DiagnosticOptions) -> String {
	match &self.invalid_option_type {
	InvalidOptionType::UnsupportedInlineDynamicFormat(format) => {
	format!("Invalid value \"{format}\" for option \"output.format\" - UMD and IIFE are not supported for code-splitting builds. You may set `output.inlineDynamicImports` to `true` when using dynamic imports.")
	}
	InvalidOptionType::UnsupportedCodeSplittingFormat(format) => {
	format!("Invalid value \"{format}\" for option \"output.format\" - UMD and IIFE are not supported for code-splitting builds.")
	}
	InvalidOptionType::InvalidOutputFile => "Invalid value for option \"output.file\" - When building multiple chunks, the \"output.dir\" option must be used, not \"output.file\". You may set `output.inlineDynamicImports` to `true` when using dynamic imports.".to_string(),
	InvalidOptionType::InvalidOutputDirOption => "Invalid value for option \"output.dir\" - you must set either \"output.file\" for a single-file build or \"output.dir\" when generating multiple chunks.".to_string(),
	InvalidOptionType::NoEntryPoint =>"You must supply `options.input` to rolldown, you should at least provide one entrypoint via `options.input` or `this.emitFile({type: 'chunk', ...})` (https://rollupjs.org/plugin-development/#this-emitfile)".to_string(),
	InvalidOptionType::AdvancedChunksWithoutGroups(options) => {
	let options_list = options.join(", ");
	format!("Advanced chunks options ({options_list}) specified without groups. These options have no effect without groups - you should either add groups to use advanced chunking or remove these options.")
	}
	InvalidOptionType::InvalidContext(options) => {
	format!("\"{options}\" is an illegitimate identifier for option \"context\". You may use a legitimate context identifier instead.")
	}
	}
	}
	}

?

I was thinking that the bundler initialization might involve not only option-related errors but also other types of errors. Therefore, I’ve temporarily grouped them all under BundlerInitializeError. For example, there’s also a tsconfig resolution error here:

Later, I’ll try to consolidate them and improve the current error kinds.

Benchmarks Rust

• target: main(af8cd90)
• pr: 09-10-feat_improve_bundler_initialization_error_handling(4ba0c62)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     91.7±3.98ms        ? ?/sec    1.01     92.3±4.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01    101.7±4.24ms        ? ?/sec    1.00    100.8±4.41ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    128.2±4.58ms        ? ?/sec    1.03    131.5±3.20ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    152.8±5.20ms        ? ?/sec    1.00    147.0±3.75ms        ? ?/sec
bundle/bundle@threejs                                        1.03     49.8±2.87ms        ? ?/sec    1.00     48.2±1.88ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     57.5±1.83ms        ? ?/sec    1.00     57.7±1.79ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01   505.2±11.92ms        ? ?/sec    1.00   499.8±11.11ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   590.7±11.58ms        ? ?/sec    1.00    583.1±9.77ms        ? ?/sec
scan/scan@rome_ts                                            1.00    103.6±4.48ms        ? ?/sec    1.00    104.1±2.87ms        ? ?/sec
scan/scan@threejs                                            1.00     36.2±2.49ms        ? ?/sec    1.03     37.4±2.11ms        ? ?/sec
scan/scan@threejs10x                                         1.01    374.0±5.53ms        ? ?/sec    1.00    370.6±6.71ms        ? ?/sec

Merge activity

• Sep 11, 2:33 AM UTC: shulaoda added this pull request to the Graphite merge queue.
• Sep 11, 2:41 AM UTC: Merged by the Graphite merge queue.