refactor(dev): task-queue based deisgn #6233

hyf0 · 2025-09-16T14:55:52Z

In the previous design, it’s hard to think about how to handle complex cases. In this design, by abstract each change into a queued task, it makes parallel events sequential, which reduces the complexity of thinking itself.

hyf0 · 2025-09-16T14:56:07Z

refactor(dev): task-queue based deisgn #6233 👈 (View in Graphite)
refactor(dev): rename WatcherEventService to BuildDriverService #6232
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/rolldown/src/dev/building_task.rs

github-actions · 2025-09-16T15:22:22Z

Benchmarks Rust

target: main(c71493c)
pr: 09-16-refactor_dev_task-queue_based_deisgn(e315e65)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.08     89.1±3.23ms        ? ?/sec    1.00     82.5±3.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     97.9±4.17ms        ? ?/sec    1.00     96.2±3.63ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    125.7±4.53ms        ? ?/sec    1.00    121.7±1.99ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    143.6±3.64ms        ? ?/sec    1.00    142.9±2.29ms        ? ?/sec
bundle/bundle@threejs                                        1.03     47.0±1.16ms        ? ?/sec    1.00     45.9±1.15ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     55.4±1.26ms        ? ?/sec    1.00     54.6±1.33ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02   486.2±10.50ms        ? ?/sec    1.00    477.3±8.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   568.5±10.80ms        ? ?/sec    1.00    562.0±8.55ms        ? ?/sec
scan/scan@rome_ts                                            1.02     99.4±2.12ms        ? ?/sec    1.00     97.7±1.92ms        ? ?/sec
scan/scan@threejs                                            1.03     35.4±0.54ms        ? ?/sec    1.00     34.5±1.51ms        ? ?/sec
scan/scan@threejs10x                                         1.00    358.4±5.44ms        ? ?/sec    1.00    358.8±5.95ms        ? ?/sec

graphite-app · 2025-09-16T15:56:49Z

Merge activity

Sep 16, 3:56 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Sep 17, 4:01 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Sep 17, 4:10 AM UTC: Merged by the Graphite merge queue.

crates/rolldown/src/dev/build_driver.rs

In the previous design, it’s hard to think about how to handle complex cases. In this design, by abstract each change into a queued task, it makes parallel events sequential, which reduces the complexity of thinking itself.

netlify · 2025-09-17T04:03:22Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`e315e65`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/68ca32bae707b100087a8585

Ref: #6233 (comment)

@Boshen

## [1.0.0-beta.39] - 2025-09-22 ⚡ MacOS Performance Boost - 10%-30% faster bundling - Up to 45% in extreme cases ### 🚀 Features - rolldown: oxc v0.90.0 + other oxc crate updates (#6274) by @Boshen - support ignoring `/* @vite-ignore */` comment for dynamic imports (#6264) by @IWANABETHATGUY - dev: merge mergeable queued tasks into one (#6253) by @hyf0 - dev: ignore self imports when computing update for invalidate (#6252) by @sapphi-red - support `#__NO_SIDE_EFFECTS__` annotation for export default function declaration (#6239) by @IWANABETHATGUY - rolldown_plugin_dynamic_import_vars: respect `@vite-ignore` comment (#6240) by @shulaoda - rolldown_plugin_import_glob: support `exhaustive` option (#6236) by @shulaoda - cross chunk /* @__NO_SIDE_EFFECTS__ */ support (#6207) by @IWANABETHATGUY - rolldown_plugin_react_refresh_wrapper: make the plugin callable (#6229) by @sapphi-red ### 🐛 Bug Fixes - handle optional chaining in scope hoisting member expression rewriting (#6278) by @shulaoda - release: Fix semver commit release format to use plus instead of dash (#6273) by @Copilot - dev: `ensure_latest_build_output` should work correctly when `eagerBuild: false` (#6262) by @hyf0 - browser: does not work in stackblitz (#6257) by @shulaoda - only inline constants that are not reassigned (#6247) by @IWANABETHATGUY - handle lexical declarations in root scope (#6230) by @IWANABETHATGUY ### 🚜 Refactor - move oxc runtime helper generation from `build.rs` to task generator (#6284) by @shulaoda - remove unused `SpanExt` (#6266) by @IWANABETHATGUY - remove `@rolldown-ignore` ignore comment support (#6265) by @IWANABETHATGUY - enhance CommonJsAstType to track property names (#6250) by @IWANABETHATGUY - simplify usage for `Address::from` (#6245) by @IWANABETHATGUY - remove `stmt_info_idx` in StmtInfo (#6244) by @IWANABETHATGUY - extract `CrossModuleOptimizationRunnerContext` in cross_module_optimization (#6243) by @IWANABETHATGUY - dev: task-queue based deisgn (#6233) by @hyf0 - extract immutable context from AstScanner (#6238) by @IWANABETHATGUY - dev: rename `WatcherEventService` to `BuildDriverService` (#6232) by @hyf0 - move FlatOptions to rolldown_common (#6235) by @IWANABETHATGUY - extract mutable state from ScopeHoistingFinalizerContext (#6234) by @IWANABETHATGUY - wait `this.load` using futures instead of callbacks (#6222) by @sapphi-red - rolldown_plugin_transform: remove unused `runtime_resolve_base` option (#6226) by @sapphi-red ### 📚 Documentation - add "edit this page on GitHub" button (#6241) by @siaeyy ### ⚡ Performance - rolldown: minor performance optimization (#6271) by @Brooooooklyn - rolldown: take advantage of tokio blocking threads (#6270) by @Brooooooklyn ### 🧪 Testing - dev: add rebuild after HMR case (#6260) by @sapphi-red - dev: support full reload in tests (#6259) by @sapphi-red - dev: extract waitFor from waitForPathExists (#6261) by @sapphi-red - add class like cases for empty function optimizations (#6248) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update github-actions (#6298) by @renovate[bot] - deps: update dependency dprint/dprint-plugin-typescript to v0.95.11 (#6296) by @renovate[bot] - deps: update dependency dprint/dprint-plugin-markdown to v0.19.0 (#6295) by @renovate[bot] - deps: update dependency g-plane/pretty_yaml to v0.5.1 (#6294) by @renovate[bot] - use a forked version of openharmony-rs/setup-ohos-sdk (#6290) by @Boshen - deps: update dependency tsdown to v0.15.4 (#6286) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.7 (#6285) by @renovate[bot] - rust: continue to make `cargo publish --workspace` work (#6281) by @Boshen - deps: update dependency tsdown to v0.15.3 (#6280) by @renovate[bot] - rust: fixes for `cargo publish --dry-run --workspace` (#6279) by @Boshen - deps: update dependency rust to v1.90.0 (#6277) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.16.6 (#6276) by @renovate[bot] - adding tracing for all sub stage in LinkStage:link (#6268) by @IWANABETHATGUY - deps: update oxc-project/setup-node action to v1.0.4 (#6258) by @renovate[bot] - deps: update github-actions (#6249) by @renovate[bot] - deps: update dependency tsdown to v0.15.2 (#6242) by @renovate[bot] - dev: output error when the initial bundle failed (#6228) by @sapphi-red ### ❤️ New Contributors * @siaeyy made their first contribution in [#6241](#6241)

github-actions bot assigned hyf0 Sep 16, 2025

hyf0 marked this pull request as ready for review September 16, 2025 14:56

hyf0 mentioned this pull request Sep 16, 2025

refactor(dev): rename WatcherEventService to BuildDriverService #6232

Merged

hyf0 force-pushed the 09-16-refactor_dev_task-queue_based_deisgn branch from c487cc9 to d29ea3d Compare September 16, 2025 15:02

graphite-app bot reviewed Sep 16, 2025

View reviewed changes

crates/rolldown/src/dev/building_task.rs Show resolved Hide resolved

crates/rolldown/src/dev/building_task.rs Show resolved Hide resolved

hyf0 force-pushed the 09-16-refactor_dev_task-queue_based_deisgn branch from d29ea3d to f3aee65 Compare September 16, 2025 15:05

hyf0 force-pushed the 09-16-refactor_dev_rename_watchereventservice_to_builddriverservice_ branch from df758e8 to 2374bd5 Compare September 16, 2025 15:05

hyf0 requested a review from sapphi-red September 16, 2025 15:06

graphite-app bot changed the base branch from 09-16-refactor_dev_rename_watchereventservice_to_builddriverservice_ to graphite-base/6233 September 16, 2025 15:43

hyf0 force-pushed the graphite-base/6233 branch from 2374bd5 to e2fa1b9 Compare September 16, 2025 15:56

hyf0 force-pushed the 09-16-refactor_dev_task-queue_based_deisgn branch from f3aee65 to f74b743 Compare September 16, 2025 15:56

graphite-app bot changed the base branch from graphite-base/6233 to main September 16, 2025 15:56

hyf0 commented Sep 16, 2025

View reviewed changes

crates/rolldown/src/dev/build_driver.rs Show resolved Hide resolved

sapphi-red approved these changes Sep 17, 2025

View reviewed changes

refactor(dev): task-queue based deisgn (#6233)

e315e65

In the previous design, it’s hard to think about how to handle complex cases. In this design, by abstract each change into a queued task, it makes parallel events sequential, which reduces the complexity of thinking itself.

graphite-app bot force-pushed the 09-16-refactor_dev_task-queue_based_deisgn branch from f74b743 to e315e65 Compare September 17, 2025 04:02

graphite-app bot merged commit e315e65 into main Sep 17, 2025
28 checks passed

graphite-app bot deleted the 09-16-refactor_dev_task-queue_based_deisgn branch September 17, 2025 04:10

hyf0 mentioned this pull request Sep 17, 2025

feat(dev): merge mergeable queued tasks into one #6253

Merged

graphite-app bot pushed a commit that referenced this pull request Sep 17, 2025

feat(dev): merge mergeable queued tasks into one (#6253)

360d733

Ref: #6233 (comment)

github-actions bot mentioned this pull request Sep 22, 2025

release: v1.0.0-beta.39 #6304

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(dev): task-queue based deisgn #6233

refactor(dev): task-queue based deisgn #6233

hyf0 commented Sep 16, 2025 •

edited

Loading

Uh oh!

hyf0 commented Sep 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

netlify bot commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(dev): task-queue based deisgn #6233

refactor(dev): task-queue based deisgn #6233

Conversation

hyf0 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

netlify bot commented Sep 17, 2025

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyf0 commented Sep 16, 2025 •

edited

Loading

hyf0 commented Sep 16, 2025 •

edited

Loading

github-actions bot commented Sep 16, 2025 •

edited

Loading

graphite-app bot commented Sep 16, 2025 •

edited

Loading