Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@romanc
Copy link
Owner

@romanc romanc commented May 31, 2025

Description

Step 1 of resolving the main / develop mess: update the main branch to contain stuff from the last couple releases.

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

oelbert and others added 30 commits August 27, 2024 13:15
…bounds_in_externals

[feature] Expose stencil vertical domain to Frozen Stencil
…reshold_override' into feature/multimodal_metric_threshold_override
…reshold_override' into feature/multimodal_metric_threshold_override
oelbert and others added 28 commits January 22, 2025 14:18
Hotfix to netcdf python version
… to halo size (NOAA-GFDL#103)

* Adding in exception for compute domains with less than 4 points to vector_halo_update method

* Updated exception in communicator to compare halo size to compute domain size

* linting

* Moved domain size checker to SubtileGridSizer class method from_tile_params
* Log on rank 0
Docstrings & typi hints on logger
Stencil Config has a `verbose` option
On verbose: FrozenStencil log when run (in GT backends)

* Update `config` in orchestrate call to solve type hint inconcistencies

* Quantity helper `to_netcdf` with multi rank support
* Added feature to enable automatic detection of integer precision. Should remove the need for i32/i64 declaration (although their functionality is still retained) and replace both with the regular Int type

* change default rebuild state to false for get_factories

* Merged Float and Int precision detection functions into one common path

* Re-added old function to fulfil a PACE dependency

* updated docstring

* Added ability to declare 32 or 64 bit IntFields, overrulling the system precision

* Added one dimensional bool fields

* Fix error message in typing.py

Co-authored-by: Florian Deconinck <[email protected]>

* output type for global_set_precision

---------

Co-authored-by: Florian Deconinck <[email protected]>
Our current DaCe version is some commit from September 2024. Meanwhile DaCe matured to v1 and recently release v1.0.1. This brings the DaCe submodule to the latest stable release version.

Co-authored-by: Roman Cattaneo <[email protected]>
Linting should give fast feedback. The current workflow takes ~3mins where most of the time is spent installing (unnecessary) python packages. To run `pre-commit`, we only need the source files and `pre-commit` itself, which can be installed standalone. This brings runtime of the linting stage down to ~30 seconds.

Other changes

- update checkout action to v4
- update python setup action to v5
- change python version from 3.11.7 to 3.11 (any patch number will do)

This is a follow-up of PR NOAA-GFDL/PyFV3#40 in PyFV3.

Co-authored-by: Roman Cattaneo <[email protected]>
* Fix the type hint of Float, Int

* Attempt using TypeAlias
* Added doc files

* Adding image files to docs

* Linting

* Updated docs to reflect changes requested in PR 97

* Linting

---------

Co-authored-by: Florian Deconinck <[email protected]>
…ailure (NOAA-GFDL#106)

* Save reports & netCDF for multiple ranks on failure
Fix multi modal threshold for parallel tests

* Order field by name in NetCDF

* Print all indices in logs. Sort by descernding ULP

* Allow sorting by metrics and index with `--sort_report` option

* Remove the `rank` froom SavepointCase. Access is done via `grid`

* Some docstrings
…ysics, including the Stefan-Boltzmann constant (NOAA-GFDL#116)

* add namelist option

* add stephan boltzmann constant

* lint

* Apply suggestions from code review

Change comments to docstring style

Co-authored-by: Florian Deconinck <[email protected]>

---------

Co-authored-by: Florian Deconinck <[email protected]>
* add ttp

* Update ndsl/constants.py

Co-authored-by: Florian Deconinck <[email protected]>

* switch comments to docstrings for autodocs

* lint

---------

Co-authored-by: Florian Deconinck <[email protected]>
* Save all fields (pass and fail) and organize them by field

* Option `--no_report` to bypass logging & netcdf save
Move logs per variable into a `details` subfolder

* Order variable name in serialbox-to-netcdf

* `extra_data_load` function to load savepoint data saved outside the canonical savepoint

* Docs / Type Hint

* Fixed typo in error statment

---------

Co-authored-by: Charles Kropiewnicki <[email protected]>
* Removed hard-code of np.float32 from NetCDFMonitor transfer_type, replaced with Float type

* Added multiple options for NetCDF precision

* Added checking for use of 32 precision and float64 output

* Using NumPy type instead of string in NetCDFMonitor precision variable

* Added warning to netcdf_monitor.py for mismatch in precision settings

* Forgot f-string in warn message of netcdf_monitor
* Ignore `.next` caches

* CNST_OP20 is a true 64-bit

* Translate: Fix reading parameters with the right precision

* Multimodal metric: Skip reporting on expected values

* Bad commit
Starting with numpy v1.25.0, `np.product()` is deprecated and
`np.prod()` should be used instead.

Co-authored-by: Roman Cattaneo <[email protected]>
…xposes control flow (NOAA-GFDL#119)

* Update DaCe to v1.0.2

DaCe v1.0.2 brings two fixes for DaCe transformations: one for
DeadDataflowElimination and one for StateFusion.

* Bump gt4py to include refactored gt4py/dace bridge

* Test with modified pace pipeline

- added this to re-trigger the new pace pipeline after limiting zarr to
  not install v3 (for now) because of breaking API changes.
- added this note to re-trigger after fixing the pace pipeline to not
  pull requirements from `develop`.
- added this note to ret-trigger after fixing the repo name

* Revert "Test with modified pace pipeline"

This reverts commit cd6560e.

---------

Co-authored-by: Roman Cattaneo <[email protected]>
* Pass `dtype` down in allocator utils (gt4py_utils)

* Allow coriolis forces to be read in

* Edge factors are always 64-bit

* Quantity QOL

* Make sure to pass `dtype` to load the grid cleanly

* Translate grid: load coriolis forces, area 64 is 64-bit

* Bad merge

* Typo
**Description**
Port and adaptation of the initial commit of the documentation.

Fixes issue NOAA-GFDL#113


**Checklist:**
- [X] I have performed a self-review of my own code
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
@romanc romanc merged commit a74d378 into main May 31, 2025
2 of 5 checks passed
@romanc romanc deleted the romanc/merge-base branch June 18, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants