chore: remove task index argument #474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been used for p99 latency investigation and not needed anymore. Signed-off-by: Roman Gershman <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the task index argument that was previously passed to callback functions in the fiber queue system. The change simplifies the callback interface by removing an unused parameter that was originally added for p99 latency investigation purposes.
Key changes:
- Updated callback function signatures to remove the unsigned id parameter
- Removed task index tracking and reset logic from the fiber queue implementation
- Cleaned up commented code and added new includes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| util/fibers/submit_entry.h | Added new system includes for file operations |
| util/fibers/fiberqueue_threadpool.h | Updated CbFunc typedef and lambda signatures to remove id parameter |
| util/fibers/fiberqueue_threadpool.cc | Removed task index tracking logic and commented scheduling code |
| util/fibers/fiber_file.cc | Updated lambda expressions to remove unused id parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been used for p99 latency investigation and not needed anymore.