@tukusejssirs Thank you for your review! I'll correct my mistakes. Sorry about them. I wasn't sure if I could use Direktórium because of copyright laws.

Sorry about them.

Be sure there’ll be more. Even I’ve made some stupid mistakes that were fixed after long time (even a year). 😉

I wasn't sure if I could use Direktórium because of copyright laws.

Well, as for the potential copyright issues, I am not sure either, however, each celebration has a single official name at any one moment of time, thus I use the best source (priority order: primary, secondary, ternary source) available to me, therefore I use Ordos/Directories as well.

I corrected the errors (except one, where I don't know which one is right). I don't have access to the Hungarian Roman Missal now, so I couldn't check if those names are correct, but I think the names in the Direktórium are correct.

I corrected the errors (except one, where I don't know which one is right).

Thanks! 🙏 You can mark my comments (in this PR) as resolved then. 😉

I don't have access to the Hungarian Roman Missal now

Just a suggestion: would it be a problem to ask the priest in your parish to let you take some pictures from the Roman Missal? It could be simply done, for example, in the sacristy after Holy Mass.

Note that you don’t have to do it, however, it would be very nice of view. Even the data from Direktórium is good enough. 😉

@MMate2007, no need to re-request my review on this PR until it is finished. As I see it, it is not yet finished, thus I don’t think we should move it from the WIP/draft state. For some reason, this PR was (twice) changed to ready to merge (non-WIP) state. I presume it might be connected to reviews and/or review requests, however, I have no idea.

IMHO at the very least we should have localised all celebrations used in the Hungarian Proper (i.e. all national celebrations should be localised, possible even diocesan celebrations) in order to consider this PR a finished one. However, when you think you won’t have much time to work on this, just tell us, I might continue the work (albeit I have no access to any liturgical books ATM, although I might gain some access if necessary).

OK, I'll work on it.

Can I ask what OCR software did you use? Just if I want to OCR something then I know this is a good software for Hungarian text.
Soon, a new Hungarian Roman Missal will be printed, and there are a lot of celebrations that aren't in the current Roman Missal (or the one on the photos).
The JSON file will be included or it is just a help for us?

Can I ask what OCR software did you use?

Tesseract. I always preprocess the images using Scantailor Advanced.

Note, however, that the output text quality depends on the input images quality. I always prefer scanning documents/books using a flatbed scanner (if possible) at 600 × 600 px resolution, otherwise I take pictures with my phone at the best light conditions possible (light room with ideally no shadows on the paper) and I place the camera in the middle of the page.

Also note that one always needs to proof (read) the documents, as I haven’t used a perfect OCR yet. YMMV

Soon, a new Hungarian Roman Missal will be printed, and there are a lot of celebrations that aren't in the current Roman Missal (or the one on the photos).

Yes, I’ve read about it. When it comes out, we need to update the strings.

The JSON file will be included or it is just a help for us?

The JSON files are intended to aid our (your?) work on romcal. Anyone can freely use it for any purposes.

Would it be possible to merge this initial work stage, even if there are still some points to verify or improve? Or do we try to have at least the Temporale strings localized (the seasons and periods)? What do you think @tukusejssirs?

@MMate2007, do you plan to continue this work soon?
In any case, the addition of this new language is a nice quality enhancement for Romcal, and we appreciate your big work on it!! 🎉

As for the remaining points to improve, what do you think about gathering them within an Issue?

Merging this first work (even at an incomplete stage) might open up new uses of Romcal in Hungarian and could encourage new contributors to contribute in this language as well 😄 (@MMate2007, if you wish to continue contributing, you are more than welcome 😊).

@MMate2007, do you plan to continue this work soon?
Yes, I'd to work on this project but I don't have a lot of time so I can't make regular changes. But if I have the time, I'll contribute.

@emagnier, give me 24h to deeply re-review the PR, then I’ll leave a comment. I’d like to localise all strings from en to hu, however, there are some other romcal tasks/issues I want to work on first.

@emagnier, I have looked into this PR and I want to add all celebration names from the Hungarian RM (ed typ 2). I need some time to do this. I presume I could make by Monday, maybe sooner. Then, we could merge this PR. All the rest keys (celebrations not celebrated in Hungary) will require much more time, therefore, it could be done in a separate PR.

Do you have any objections?

@emagnier, @MMate2007, I have pushed a commit to the repo (@MMate2007, don’t forget to pull the changes before you do anything with your hungarian-translate branch). I have added 49 localised celebrations (plus some those where patronage titles were added) out of 253 (all of them are sourced from RM ed typ 2).

Some notes:

• I am not sure whether patrick_of_ireland_bishop_patron_of_ireland should be védőszentje or rather fővédőszentje, just like stephen_i_of_hungary and benedict_of_nursia_abbot_patron_of_europe.
• A győri Könnyező Szűz Mária (literally: Weeping Virgin Mary of Győr): here I can find that in English, they call her Our Lady Queen of Ireland, Consoler of the Afflicted. I am not sure how to localise this celebration name, therefore I have skipped its addition for now (it could be added before merging this PR, however, as it is not yet used, it could be added in a separate PR in which we add the diocesan calendar of Győr).
• I am not sure whether joseph_spouse_of_mary_patron_of_canada should be védőszentje or rather fővédőszentje, however, I presume that this patron is a secondary patron and St Anne is the principal patron of Canada.

I won’t work on this tonight anymore, I’ll probably revisit this PR tomorrow evening CEST. 🥱 👋

@MMate2007, if you want to work on adding the celebrations from the Roman Missal, you can use this list. Last celebration name I added was Soubirous Szent Mária Bernadett szűz, therefore, you can continue with Szent Anzelm püspök és egyháztanító. 😉

I have localised all the seasonal strings according to the sources available to me. They should be, however, still verified (esp using mr_hu_2022_ed3) in order to make sure they are correctly localised.

I have added the following tasks to this comment of mine. I won’t update the list here, but in that comment. I just want to notify you guys (esp you, @MMate2007) that they are added to that comment.

• verify with mr_hu_2022_ed3:
  • .seasons.paschal_triduum.season: I am not sure whether we should keep the initial definite artitle (A) or not:
    • it is printed in Ordo 2022, however, no other season has it;
  • I haven’t found a source for these keys, I simply translated the usual format used, e.g., in English and Slovak:
    • .seasons.christmas_time.day (I used ${weekDayName} karácsonyi időben, e.g Hétfő karácsonyi időben);
    • .seasons.christmas_time.before_epiphany (I used ${monthName} ${dayInMonth}., e.g December 17.);
    • .seasons.christmas_time.after_epiphany (I used ${weekDayName} az Úrunk megjelenése után, e.g Hétfő az Úrunk megjelenése után);
  • .color.purple: I have changed it to viola (as per Ordo 2022), although lh.kbs.sk/hu uses lila;
  • .color.gold: I could not find a source for this colour, but it should be correct;
  • .color.rose: the colour name in Ordo 2022 is shortened to rózs., but again, it should be correct;
  • .cycles:
    • .cycles.proper_of_time and .cycles.proper_of_saints:
      • I am not sure how to translate these keys;
      • I simply ‘hungarianised’ their Latin counterparts and provided some third-party sources for them;
      • I could imagine that mr_hu_2022_ed3 translates them something like A szentek saját része, as it is in mr_sk_2021_ed3, however, I could not find a similar translation for the Proper of Time (Az idők saját része?);
    • all the other cycles:
      • I simply kept the translations of @MMate2007, as they seem to be correct, but sourcing them from the Ordo 2022 seems to me bad;
• test the romcal generation out using the hu locale.

@MMate2007, right now, I am in the middle of uploading the images of mr_hu_2022_ed3 I have asked a friend of mine to take. If you have time, you could update hu. If not, I’ll do it, however, I’d to OCR them (only *_cal_*.jpg and *_index_of_celebrations.jpg).

Can we rebase + merge at least this initial part of the work?

And is it possible to add these translations at least in this PR (with the help of a translation tool if necessary, unless @MMate2007 you can provide them for us, even simply in a comment here)?

WARN  Missing localized 'hu' items for the Proper of Time and the General Roman Calendar:
  ranks:
       - optional_memorial
  names:
       - easter_sunday
       - gregory_of_narek_abbot
       - paul_vi_pope
       - apollinaris_of_ravenna_bishop
       - peter_julian_eymard_priest
       - catherine_of_alexandria_virgin

This will allow us to make progress more smoothly on this translation work (having a first operational hu version in Romcal). And since we are currently doing some large refactoring on the project, it will prevent us from having to maintain this PR open any longer.