Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@miguelms95
Copy link
Contributor

Is "San Isidoro de Sevilla, obispo y doctor de la Iglesia" not "Isidro"
https://liturgiapapal.org/attachments/article/1093/PROPIO%20DE%20LOS%20SANTOS.pdf#page=5

@miguelms95 miguelms95 changed the title Feat/fix isidore saint Feat/fix isidore saint translate Spanish. Apr 26, 2024
@miguelms95
Copy link
Contributor Author

@emagnier please check when possible :)

Copy link
Member

@tukusejssirs tukusejssirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelms95, thanks for this PR! 🙏

The Proper does not use de Sevilla for the saint, thus it should be removed from romcal. After changing this, this PR looks all good to me.

@miguelms95
Copy link
Contributor Author

Done! @tukusejssirs 👍🏼

@tukusejssirs
Copy link
Member

tukusejssirs commented Apr 26, 2024

Anyway, could you fix the commit messages please? See the CI log.

And you should rebase your changes on top of dev. Maybe the easiest way is to:

  • back up es.ts;
  • change the HEAD of your feature branch (feat/fix-isidore-saint) to point to that of dev (git fetch upstream && git reset --hard upstream/dev; this presumes you have added an upstream remote to Git by git remote add upstream https://github.com/romcal/romcal.git && git remote set-url --push upstream no_push);
  • restore your changes;
  • create a new commit (e.g. fix(es): fix the localisation of isidore_of_seville_bishop);
  • force-push your changes.

@miguelms95 miguelms95 force-pushed the feat/fix-isidore-saint branch from b4438c0 to f6bf65c Compare April 26, 2024 16:20
@miguelms95 miguelms95 force-pushed the feat/fix-isidore-saint branch from f6bf65c to 55ab2d8 Compare April 26, 2024 16:23
@miguelms95
Copy link
Contributor Author

Done! ✅ @tukusejssirs thanks for the detailed reply. Now there's only a commit haha 👍🏼

Copy link
Collaborator

@emagnier emagnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for the fix and the review 🚀

@emagnier emagnier merged commit 1a244c8 into romcal:dev Apr 26, 2024
@miguelms95 miguelms95 deleted the feat/fix-isidore-saint branch April 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants