-
Notifications
You must be signed in to change notification settings - Fork 60
Feat/fix isidore saint translate Spanish. #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@emagnier please check when possible :) |
tukusejssirs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelms95, thanks for this PR! 🙏
The Proper does not use de Sevilla for the saint, thus it should be removed from romcal. After changing this, this PR looks all good to me.
|
Done! @tukusejssirs 👍🏼 |
|
Anyway, could you fix the commit messages please? See the CI log. And you should rebase your changes on top of
|
b4438c0 to
f6bf65c
Compare
f6bf65c to
55ab2d8
Compare
|
Done! ✅ @tukusejssirs thanks for the detailed reply. Now there's only a commit haha 👍🏼 |
emagnier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for the fix and the review 🚀
Is "San Isidoro de Sevilla, obispo y doctor de la Iglesia" not "Isidro"
https://liturgiapapal.org/attachments/article/1093/PROPIO%20DE%20LOS%20SANTOS.pdf#page=5