Conversation
Contributor
|
Hi @emagnier, |
Collaborator
Author
|
@gtortone you are right, new keys have been added in our working branch. No problem :) And thanks! |
tukusejssirs
approved these changes
Dec 4, 2019
Member
tukusejssirs
left a comment
There was a problem hiding this comment.
Good to go!
However, I’ve just suggested that we might want to replace ' with ’ (same would apply in other l10n files, e.g. fr.js).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the permission of @gtortone, I'm opening here a commit with his big work of translation 🇮🇹.
Thanks @gtortone for this amazing work! 🎉
This PR is open on the
romcal-es6branch, since there is currently some refactors in progress on locales and keys. It will be easier to take care of the new Italian locales in the same time.I've also added a commit, to fix some duplicated keys. But this highlight that we need to find a more standard way to write them. @tukusejssirs you suggested somewhere to remove saint/blessed to simplify key names (that would make also reading easier in the locales files). It's something that we should consider and move forward on that.