Various bugfixes. #111
Various bugfixes. #111
Conversation
… Polish translation. Fixes romcal#106. English translation is going to be added with 00c1257
…uary. Fixes romcal#40. TODO: if Jan 1 is Sunday (e.g. year 2017), there's no baptismOfTheLord in romcal. Should check what happens in Philippines in this case.
|
@jarosz Please don't merge PR yourself when there things we should review first. |
|
@jarosz, could you create separate PRs for each bug/issue fix? This PR resembles one of your previous PRs, currently deemed to doom as |
|
@emagnier, I reviewed the changes in this PR and I could not find an issue. However, because @jarosz did not include the One issue, non-related to the modified files directly, is that the changes where not recorded in I suggest that the merges should be done exclusively by @emagnier as (1) he is currently the maintainer; (2) only one person should create merge commit. I think we should revert this commit or at least do an amend commit. |
|
@jarosz Yes we really appreciate your help to fix bugs, but we are working together so you can't open/merge PR like that. This isn't correct. Also it's important to document what has been fixed, in the description of this PR and the HISTORY.md file. @tukusejssirs thanks for your review. And thanks for your suggestion about merging things. I think we should try that way. |
|
Also fo the fixed things, we could close the related issues. |
|
Please move the discussion about my commits to romcal-contributors. I don't want to make harm. |
No description provided.