Avoid leaking an open socket #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connecting through a socks proxy to a non-existing or non-functional server such as `example.com` with the trio implementation, a warning is raised:
```
ResourceWarning: unclosed <socket.socket fd=15, family=2, type=1, proto=0, laddr=('127.0.0.1', 63402)>
import gc; gc.collect()
Object allocated at (most recent call last):
File "python-3.13/lib/python3.13/site-packages/trio/_socket.py", lineno 381
stdlib_socket = _stdlib_socket.socket(family, type, proto, fileno)
```
This is the same issue with trio as 2e4f5ca was with asyncio.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
Author
|
This time I checked if the other implementations are vulnerable to the same issue. It looks like they aren't — or at least it's their responsibility not ours ;-) Other than in asyncio and trio, we create the socket directly with a high-level API; we don't do the create/bind/connect sequence. |
Contributor
Author
|
I double-checked and tested that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting through a socks proxy to a non-existing or non-functional server such as
example.comwith the trio implementation, a warning is raised:This is the same issue with trio as 2e4f5ca was with asyncio.