Only copy if cell is present when expand_merged_ranges: true #507
Conversation
|
Hello, I see that there are tests available for Is this okay? I'd like to figure out how to add a test for this to assert that we don't copy nil cells. Or should I just add the example file from the issue? |
|
I haven't looked at this, but if |
|
I just looked into filter during node selection, but there does not appear to be any difference: |
2acee5a to
15826d6
Compare
If you merge empty cells, the definitions for merged ranges references the appropriate coordinates for the merge, but the cells hash does not include a value at that coordinate. When copying the src to dst, we end up copying `nil` into the `cells` hash which causes errors in several other parts of parsing.
I just pushed a commit with a test for this condition, which included me editing |
|
@chopraanmol1 / @amoniacou would you mind taking a look at this? I was asked by a coworker if this patch was accepted yet and I noticed this hasn't been looked at yet. I'd love to make whatever changes necessary to get this accepted. Thanks! |
|
@chopraanmol1 Can you please review this, or ping someone else that might be appropriate to review and accept this PR? Thank you for your time. |
This fixes #506 where
expand_merged_ranges: truewas shown to createnilin the@cellshash. This then would cause other issues where cell objects were expected to exist (such as duringclean: true).