Support formatting excel currencies #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmidgley
commented
Mar 12, 2021
| when '#,##0.00;[Red](#,##0.00)' then number_format('%.2f', '[Red](%.2f)') | ||
| # FIXME: not quite sure what the format should look like in this case. | ||
| when '##0.0E+0' then '%.1E' | ||
| when "_-* #,##0.00\\ _€_-;\\-* #,##0.00\\ _€_-;_-* \"-\"??\\ _€_-;_-@_-" then number_format('%.2f', '-%.2f') |
There was a problem hiding this comment.
This expression is similar but it isn't defended with a spec so I can't tell if I could handle it too. It also appears to discard the €--we expect to have it in the formatted value.
|
@simonoff is this something you can review for merge? We are using it in prod and it's working out fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Can formatted currencies include the currency symbol? This PR adds Roo support for calling format on a currency-formatted cell and getting a value with the currency symbol back.
Other Information
There is a simple format for US currencies and a more complex form for others. Anything that's not a US currency appears to shift the format entirely from "Currency" to "Accounting".
The accounting format appears to be multiple functions which probably need a new library to fully execute. What I do instead is look for a pattern in the first function that appears to identify the currency symbol and digital formatting.
The sample I got for applying Euro formatting is:
([$€-2]\ * #,##0.00);([$€-2]\ * (#,##0.00);([$€-2]\ * "-"??);(@_)
And I just used the first part and extracted the currency symbol and format there.