Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@emilford
Copy link
Contributor

@emilford emilford commented Jan 28, 2024

https://github.com/nvim-neotest/neotest/

πŸ‘‹ I'm switching to the Neotest runner and instead of adding theme support to my own set up I figured I'd add it to the plugin directly. I matched the colors roughly to those used by default in the plugin. I'd appreciate any suggestions to make the color selections better align with the intentions of the theme and anything else needed to merge (e.g., do I need add to the transparency_highlights list as well?). Thanks!

@mvllow
Copy link
Member

mvllow commented Jan 28, 2024

Thank you for adding support for a new plugin! I trust your judgement on the colours but if you want to share a screenshot I can perhaps give feedback. For the transparency highlights, these shouldn't be necessary for this PRβ€”there only seems to be one new highlight that has a background colour anyways :)

@emilford
Copy link
Contributor Author

Hi @mvllow,

I think it looks pretty good and with some of the recent changes aligns with colors from other rose-pine plugins. But please let me know if you have any suggestions. A few screenshots below. The "has the expected schedule" is a focused test; the "schedule geocode properties" is a marked test; neotest-rspec is the adapter/runner. Thanks!

w/ passing tests

CleanShot 2024-01-27 at 20 49 47@2x

w/ tests running

CleanShot 2024-01-27 at 20 51 22@2x

w/ failing tests

CleanShot 2024-01-27 at 20 50 43@2x

@mvllow
Copy link
Member

mvllow commented Jan 28, 2024

I love it, wonderful job. I don’t think I’d change anything

@emilford emilford marked this pull request as ready for review January 28, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants