Update package to reflect new 2.2.0 namespace #40
Conversation
Per ropensci#39, EML's final schema URI space now begins with https://eml.ecoinformatics.org/{module}-{version} instead of eml:// like in the past. Both EML and STMML namespaces were updated for EML 2.2.0 docs (STMML gets updated because EML 2 uses STML 1.2)
This adds a custom Dockerfile based on rocker/verse that lets jqr be installed in the container so the tests pass. Couple of other minor tweaks to clean related things up.
|
Thanks for cranking through this - yeah this one must have been a bit of a beast to change with so many places that namespace is hardwired in test and example files. I've skimmed through all the changes and looks good! (some whitespace trimming makes them look even more sweeping than they really are, but oh well). Only thing -- I don't think you created an entry in NEWS.md describing this change yet? Can you bump the package version to Also, is this a good point to cut a new release to CRAN or can you think of any other things we might want to tackle in the near-term first? |
|
Thanks for this @amoeba. Before cutting the new release, we might want to switch back to setting the default EML version to 2.2.0 now that this is officially out. I created an issue requesting the switch to 2.1.1 until 2.2.0 got released. |
|
p.s. @amoeba Just for reference, ropensci's docs server builds pkgdown automatically now as part of the nightly checks, so no need to build it locally. Should probably drop it from the repo here. See https://docs.ropensci.org/emld/ for the auto-generated docs and http://packages.ropensci.org/job/emld/ for the Jenkins job log that creates these. All 🎩 work from @jeroen 😄 |
|
Slick, nice work @jeroen ! |
Between the last sync and the final 2.2.0 release, we:
eml://eml.ecoinformatics.org/eml-2.2.0tohttps://eml.ecoinformatics.org/eml-2.2.0to move forward with a more standard namespace scheme since everyone minting their own custom schemes never took off and we centralized around HTTP(S).annotationelementThis PR basically:
eml://...to be dynamic based up on version, using the newhttps://...prefix when appropriate.Other stuff I ended up doing:
jqCould use a quick sanity check as it's quite a lot of change.
Closes #39.