refactor vfs so that append and update can also work ref #88 #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainsawriot
added a commit
that referenced
this pull request
Jan 21, 2023
The XML escaping is kind of hacky, but highly optimized based on `stringi`. There is a slight penalty in performance due to the additional escaping activity, but it is still much much much faster than `v1.7.3`. The whole enterprise of #88, #89, and this still needs a lot of fuzzing (#93) to ensure correctness and safety. --- * add implementation of XML escaping #1 #88 * make both values escaped in `.cell_out` * Add final benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.