Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add preventive measure against #180 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chainsawriot merged 2 commits into from
Nov 3, 2023
Merged

Add preventive measure against #180 #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
872b51d
Add preventive measure against #180
chainsawriot Nov 2, 2023
1d14dec
Specify the minimal cpp11 version
chainsawriot Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Imports:
vctrs (>= 0.4.2),
zip
LinkingTo:
cpp11
cpp11 (>= 0.4.6)
Suggests:
spelling,
testthat,
Expand Down
4 changes: 3 additions & 1 deletion src/write_sheet_file_.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ cpp11::r_string write_sheet_file_list_(const std::string& filename,
xml_file << header;
cpp11::strings sheet_names = x.names();
for (int i = 0; i < sheet_names.size(); i++) {
write_df(x[i], sheet_names[i], row_names, col_names, na_as_string, padding, xml_file);
cpp11::data_frame current_df = x[i];
cpp11::r_string current_sheet_name = sheet_names[i];
write_df(current_df, current_sheet_name, row_names, col_names, na_as_string, padding, xml_file);
}
xml_file << footer;
xml_file << "\n";
Expand Down