Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #211 #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chainsawriot merged 1 commit into from
Jan 12, 2025
Merged

Fix #211 #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ URL: https://docs.ropensci.org/readODS/, https://github.com/ropensci/readODS
BugReports: https://github.com/ropensci/readODS/issues
Imports:
cellranger,
minty,
minty (>= 0.0.5),
stringi,
tibble,
vctrs (>= 0.4.2),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Fix #207, trim off large or unused test files
* Fix #209, require R >= 4.0.0 due to `cpp11`
* Fix #211, fix a bug (in minty) for parsing cells with only spaces

# readODS 2.3.1

Expand Down
Binary file added tests/testdata/test_may_make_read_ods_crash_v2.ods
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions tests/testthat/test_read_ods.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,7 @@ test_that("Warns of empty sheet", {
expect_warning(read_fods("../testdata/empty.fods"))
})
})

test_that("minty v0.0.5 #211", {
expect_error(read_ods("../testdata/test_may_make_read_ods_crash_v2.ods", trim_ws = TRUE), NA)
})
Loading