Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rely more on function arguments than YAML config #483

@wlandau

Description

@wlandau

Prework

  • Read and agree to the code of conduct and contributing guidelines.
  • If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.
  • [n/a] For any problems you identify, post a minimal reproducible example like this one so the maintainer can troubleshoot. A reproducible example is:
    • [n/a] Runnable: post enough R code and data so any onlooker can create the error on their own computer.
    • [n/a] Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
    • [n/a] Readable: format your code according to the tidyverse style guide.

Description

After #481, most targets functions have arguments to specify the target script path and data store path. These arguments work by temporarily changing global config settings for the function call. In an ideal world, the YAML config settings should just set default arguments. The YAML should serve the arguments, not the other way around.

Also, the config argument of tar_config_set() sets a transient value that vanishes when the session restarts, which breaks the session independence that targets is supposed to follow.

I intend to do a bunch of cleanup for all this. It should simplify some of the infrastructure, e.g. getting rid of the config class.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions