-
Notifications
You must be signed in to change notification settings - Fork 76
Configurable file paths #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @nsheff. You can now do things like |
Ensures internals remain consistent with each other.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Related GitHub issues and pull requests
Summary
With efforts like Target Markdown and https://github.com/wlandau/targets-shiny,
targets
is becoming more of a backend tool. That means it needs to be more configurable. As of this PR,targets
now has functionality to configure the target script file (default:_targets.R
), the data store (default:_targets/
), and the YAML file with configuration settings (default:_targets.yaml
). You can override the settings for a function call using thescript
andstore
arguments (and theconfig
argument oftar_watch()
andtar_watch_server()
).With the exception of
tar_config_set()
, the argumentsscript
,store
, andconfig
operate by temporarily modifying in-memory global config settings. This technique avoids a lot of painful refactoring, but it also means these arguments will cause bugs if R ever becomes arbitrarily multithreaded. Since arbitrary multithreading is almost surely never going to happen, I am willing to make this tradeoff. Knowing what I know now, if I were to designtargets
from the beginning, I would delegate the file paths to various internal classes. But doing that at this stage would be a staggering amount of effort for something that is never going to impact usage or maintainability.