add tar_load_all()
#823
Merged
add tar_load_all()
#823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point about the name, I like |
wlandau
reviewed
Apr 15, 2022
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Related GitHub issues and pull requests
tar_load()should beeverything()#772Summary
Please explain the purpose and scope of your contribution.
This PR adds a small helper function,
tar_load_all(), which loads all targets.A point of discussion: I stuck with
tar_load_all()like you suggested, but it occurs to me that a user of devtools might expect this function to do something slightly different e.g. load all functions that the pipeline is using, more similar to whatload_all()does. Do you think that's an issue?tar_load_everything()is accurate but a bit long (if a non-issue thanks to autocompleting).